 | Steema Issues DatabaseNote: This database is for bugs and wishes only. For technical support help, if you are a customer please visit our online forums;otherwise you can use StackOverflow. Before using this bug-tracker we recommend a look at this document, Steema Bug Fixing Policy. |
Bug 495
| Summary: | Buffer overrun in TSeriesBandTool.DrawBandTool | ||
|---|---|---|---|
| Product: | VCL TeeChart | Reporter: | Marc Durdin <marc.durdin> |
| Component: | Series | Assignee: | Steema Issue Manager <issuemanager> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | major | CC: | david |
| Priority: | --- | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows | ||
| Chart Series: | --- | Delphi / C++ Builder RAD IDE Version: | |
This problem should be fixed in latest sources. Can you attach here a test project? In the latest version, DrawBandTool had been changed quite a bit and there shouldn't be any overrun. Also, the series DrawBetweenPoints property is no longer used. (DrawBetweenPoints is True for series that need to paint in-between one point and the next point, like Line or Area series). |
The TSeriesBandTool.DrawBandTool function has a buffer overrun when it writes to the tmpPoints array. Specifically, the length of the array is short by 2, 3, or 4 values. The following code increments the length of the array, but then is not checked correctly when starting the iteration: // First point outside chart if Series.DrawBetweenPoints and (Series.FirstValueIndex>0) then Inc(l1); ... tmpMax:=Math.Max(0,Series.FirstValueIndex-1); The fix should either be: a) test for Series.DrawBetweenPoints when calculating tmpMax; or b) don't test for Series.DrawBetweenPoints when calculating l1. And the same fix must be applied for Series2.DrawBetweenPoints/l2. I not not entirely clear on which is the appropriate solution, as I don't understand the reasoning behind the initial check for Series.DrawBetweenPoints.